Custom fields: insert path and query args to form before submitting #53324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
ramonjd
requested review from
marekhrabe,
noisysocks,
ellatrix and
tellthemachines
|
Size Change: +65 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
ramonjd
changed the title
noisysocks
reviewed
Aug 7, 2023
packages/edit-post/src/components/preferences-modal/options/enable-custom-fields.js
Outdated
Show resolved
Hide resolved
noisysocks
approved these changes
Aug 7, 2023
…th saved content, the window is refreshed on the page that is first loaded, that is, /wp-admin/post.php and not, for example, ?post=27&action=edit. This is because the toggle-custom-fields-form uses the first admin URL is finds when it is rendered to the page and is not updated after a post is saved.
…custom fields is not working.
ramonjd
force-pushed
the
update/insert-current-path-and-args-after-custom-post-refresh
branch
from
9bb95bb to
74150a9
Compare
ramonjd
deleted the
update/insert-current-path-and-args-after-custom-post-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #53323
Inserts the path and query args into the
#toggle-custom-fields-form [name="_wp_http_referer"]input value before page refresh.Why?
When activating the custom fields preference on a new post or page with saved content, the window is refreshed on the page that is first loaded, that is,
/wp-admin/post.phpand not, for example,?post=27&action=edit.This is because the toggle-custom-fields-form uses the first admin URL is finds when it is rendered to the page and is not updated after a post is saved.
How?
See "what"
Testing Instructions
Screenshots or screencast
2023-08-04.14.58.06.mp4