Column: exit on Enter #53311
Merged
Column: exit on Enter #53311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
kevin940726,
Mamaduka and
ajitbohra
as code owners
|
Size Change: +1.02 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Thanks for the review! |
SiobhyB
added
[Feature] Blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #52774.
Why?
How?
Adds
__experimentalOnEnterto thecolumnblock, so Enter in an empty paragraph at the end of the block moves the paragraph outside of the column. Had to modify it to search for the first parent block where a paragraph is insertable (withcanInsertBlockType), because we can't simply move it to the columnS block, it needs to be moved up one more parent.We also don't want to enable splitting the column block in the middle, so I disabled that by returning early with a
canInsertBlockTypecheck.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast