Improve metrics on post publish view buttons #53245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -56 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6737b22. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5729776562
|
|
Much better, thank you for the attention to detail! Can we change this 8px gap to also be 16px? 
And do you know why this panel has a special curiously dark-gray treatment for the disabled input? It looks like it's local to just this input field: 
The fact that we could use a better disabled-input design across all inputs is a separate issue, but until we can improve that it seems curious that there's a local override here. Can we remove it? |
|
Oh, while I'm here, I wonder if we should reduce the button labels:
Not a strong opinion and probably, but the "Post" seems implied, and any time we can remove the CPT type usually translation benefits from it. Also, what's the capitalization story here? I seem to recall us avoiding titlecase 🤔 |
richtabor
force-pushed
the
tweak/pre-publish
branch
from
6737b22 to
f17b529
Compare
@jasmussen I don't, but is this the only readonly input? I used the disabled styling from the design library, but kept the color value (as it's not entirely disabled). Also added the gap. 
They're currently using the post type's view item and add new item labels, like this: I don't mind a follow-up to not use those labels, and simplify to View and Add new though. 🙂 |
jasmussen
approved these changes
Aug 14, 2023
richtabor
changed the title
|
Just noticed that increasing the left/right padding of the URL readonly input as shown in the last screenshot broke the text-overflow ellipsis in Firefox. Firefox:
Chrome:
Besides that, I'd think the left/right padding is unnecessarily a bit too big and uneven with the top/bottom one. Edit: weirdly enough, it's the top/bottom value that breaks the ellipsis in firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tidying up the post publish view to get it better in line with existing UI.
Testing Instructions
Screenshots or screencast