-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile - KeyboardAwareFlatList - Avoid VirtualizedList console error #53237
Conversation
…latList component to avoid an error message, scroll is not actually needed within the FlatList since the ScrollView is the component that handles it
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
Flaky tests detected in 1cc77d8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5728430851
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test plan succeeded for me with an iPhone SE running iOS 16.5.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 ! So happy to finally remove this error log that has been for so long 😅 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related PRs:
What?
This PR removes a console error related to nesting a VirtualizedList (FlatList) within a ScrollView in the KeyboardAwareFlatList component.
Why?
To avoid having to discard it constantly while developing.
How?
In React Native
0.71
a new check was added for nested VirtualizedLists to avoid displaying the console error if it hadscrollEnabled
set to false. For this case, the ScrollView is the component that handles the scrolling so we can disable it for the FlatList.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
VirtualizedListError.mov