Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README to the useSetting component #53162

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add README to the useSetting component #53162

merged 2 commits into from
Aug 3, 2023

Conversation

ingeniumed
Copy link
Contributor

What?

This will add a README for the useSetting component, with relevant details and examples of usage.

Why?

This will resolve #52079

How?

The README is what's needed to resolve that issue.

Testing Instructions

N/A

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@ingeniumed
Copy link
Contributor Author

I'm am not able to add the developer-documentation label to this PR unfortunately that would resolve the above problem.

@juanmaguitar juanmaguitar added the [Type] Developer Documentation Documentation for developers label Jul 31, 2023
@juanmaguitar
Copy link
Contributor

I'm am not able to add the developer-documentation label to this PR unfortunately that would resolve the above problem.

@ingeniumed label has been added.

Thanks a lot for working on this issue

Copy link
Contributor

@mburridge mburridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ingeniumed
Copy link
Contributor Author

Thanks for approving it! You would need to merge it in as well, as I don't have permission to merge it unfortunately.

@mburridge
Copy link
Contributor

Merged

@mburridge mburridge closed this Aug 1, 2023
@ingeniumed
Copy link
Contributor Author

@mburridge - I think you closed the PR instead of merging it in. Would be able to re-open and merge it in?

@tellthemachines tellthemachines enabled auto-merge (squash) August 3, 2023 04:26
@tellthemachines tellthemachines merged commit b2e5f0d into WordPress:trunk Aug 3, 2023
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 3, 2023
@ingeniumed ingeniumed deleted the add/readme-to-use-setting branch August 3, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add README.md file for use-setting component
4 participants