Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes: Add typography, dimensions, and border block supports #53044

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

mikachan
Copy link
Member

What?

This updates the block supports for the Footnotes block to include typography, dimensions, and border controls. It also adjusts the color supports so that link and text are the defaults, rather than background and text.

Why?

This gives the Footnotes block further design flexibility. Follow-on from #52897, and addresses this comment: #52897 (comment).

How?

Updates the Footnotes block.json file.

Testing Instructions

  1. Open the Post Editor
  2. Add some text
  3. Highlight some text, use the drop down menu in the block toolbar to add a footnote
  4. Open block settings for the footnote and ensure that there are typography, dimensions and border controls
  5. Please try applying controls from the available options; make sure the settings are applied in the editor and the front end

Screenshots or screencast

Default settings for the Footnotes block with this PR:

image

@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Block] Footnotes Affects the Footnotes Block labels Jul 27, 2023
@mikachan mikachan requested a review from ajitbohra as a code owner July 27, 2023 14:10
@mikachan mikachan self-assigned this Jul 27, 2023
@ndiego
Copy link
Member

ndiego commented Jul 27, 2023

I have added this to the 6.3 Project Board. While we are very late in the release cycle, I believe the Footnotes block fundamentally needs these block supports. Since the Footnotes block is included for the first time in 6.3, we should try and provide the best user experience possible.

@MaggieCabrera
Copy link
Contributor

Yes please, let's get these in with the block

@t-hamano
Copy link
Contributor

t-hamano commented Aug 1, 2023

My understanding is that after the Beta release, it becomes a feature freeze, and in principle, new features should not be able to be added. It pains me too that this feature is not available, but how about removing it from the 6.3 project board?

It might also be a good idea to add these added block supports to the table of each block support tied to the #43241 tracking issue.

@mikachan mikachan added the [Package] Block library /packages/block-library label Aug 2, 2023
@mikachan
Copy link
Member Author

mikachan commented Aug 4, 2023

I'm going to merge this, as it's a follow-up to #52897 which will be included in GB 16.4, and it would be nice to also include this PR in 16.4 ✨

@mikachan mikachan added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Aug 4, 2023
@mikachan mikachan merged commit de67122 into trunk Aug 4, 2023
@mikachan mikachan deleted the update/footnotes-block-supports branch August 4, 2023 11:58
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 4, 2023
mikachan added a commit that referenced this pull request Aug 9, 2023
)

* Remove background and add link to default color controls

* Add typography, dimensions, and border controls
@mikachan mikachan removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Aug 9, 2023
@mikachan
Copy link
Member Author

mikachan commented Aug 9, 2023

I just cherry-picked this PR to the release/16.4 branch to get it included in the next release: 98fe154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block Needs User Documentation Needs new user documentation [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants