Add Open styles revisions command conditionally
#52945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +523 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jul 25, 2023
|
This is working well, and the logic of only showing commands when the UI is ready makes sense to me. Thanks for getting it up so quickly! 2023-07-26.17.04.25.mp4Checking for an empty revisions array will also correspond well with this PR (if it ever gets in): |
mikachan
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #52865 (comment)
This PR adds the
Open styles revisionscommand conditionally, only if there are any revisions.Testing Instructions
Open styles revisionscommand and observe it's not availableOpen styles revisionscommand and observe it is available