-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further bugfixes for 6.3 RC2 #52915
Further bugfixes for 6.3 RC2 #52915
Conversation
* Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures
* Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <[email protected]>
* Update style.scss * Update style.scss
* Check if object exists before accessing its properties. * Name anonymous functions * Update names
* If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself
Size Change: +216 B (0%) Total Size: 1.45 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all commits in the list according to their PR descriptions
LGTM
🙇🏻
@tellthemachines, @ramonjd, is there a time to include one or two more PRs? |
Both approved. Just waiting for CI to pass on #52916 |
Thanks and sorry for last minute PRs 🙇 |
* ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <[email protected]>
Latest commits LGTM |
$footnotes = get_post_meta( $post_id, 'footnotes', true ); | ||
|
||
if ( $footnotes ) { | ||
// Can't use update_post_meta() because it doesn't allow revisions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Adds the following bug fixes to the 6.3 release branch:
Sidebar: Restore Back buton 'go to parent' functionality
Disambiguate "Import" button string.
Site Editor: Fix the template parts link on the list page
Check if object exists before accessing its properties.
Distraction Free: Add missing command in site editor
Distraction Free Keyboard Shortcut: Fix notices in site editor
Global styles revisions: display text if no revisions are found
Image: Use the correct method for caption class in recent deprecation
Fix image block v6 deprecation
Return focus more from focus return hook
My patterns page: Increase color contrast for the toggle group
Distraction Free: Fix conflict with showListViewByDefault preference
Site Editor: Don't navigate to the patterns in Template Parts mode
Site Editor: Open template parts from the list page in canvas view mode
ResizableFrame: Account for window resizing