Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes: fix PHP unit failures for revision handling #52879

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

What?

See #52686 (comment).

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix marked this pull request as ready for review July 24, 2023 10:38
@ellatrix ellatrix requested a review from ajitbohra as a code owner July 24, 2023 10:38
@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 24, 2023
@github-actions
Copy link

Flaky tests detected in 41d87c0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5643833064
📝 Reported issues:

@ramonjd
Copy link
Member

ramonjd commented Jul 25, 2023

Fixed in #52870

@ramonjd ramonjd closed this Jul 25, 2023
@ramonjd ramonjd deleted the fix/fn-php-unit-failures branch July 25, 2023 04:43
@ramonjd
Copy link
Member

ramonjd commented Jul 25, 2023

Thanks for putting up this PR! A few changes had to be made based on feedback in the backport patch so the PHP unit fix was added there. 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants