Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocks to specify that they can't be made reusable #5280

Closed
wants to merge 1 commit into from

Conversation

noisysocks
Copy link
Member

Closes #4722.

Description

Allows blocks to specify that they can't be made reusable by setting supports.reusable to false.

Right now, the Columns (experimental) block is the only core block that we don't support converting into a reusable block. @aduth is working on that over in #5228.

How to test

  1. Create a block
  2. Click on the 'More options' ellipsis and convert it to a reusable block
  3. Create a Columns (experimental) block
  4. Click on the 'More options' ellipsis and verify that you cannot convert it to a reusable block

Don't allow converting any block with `supports.reusable == false` to a reusable block.
@noisysocks noisysocks added [Feature] Block API API that allows to express the block paradigm. [Feature] Extensibility The ability to extend blocks or the editing experience labels Feb 27, 2018
@noisysocks noisysocks requested a review from aduth February 27, 2018 04:12
@mtias
Copy link
Member

mtias commented Feb 27, 2018

@noisysocks I'm not sure we should add this — see last reply in #4722. Would like to know more about the use cases this would address.

@noisysocks
Copy link
Member Author

Let's hold off for now, then. Further discussion in #4722 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants