Add keyboardReturn submit button back to LinkControl #52620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Regression
|
Size Change: +152 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
We removed this when we added the |
getdave
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Let's update the unit tests that cover the creation of links to include the UI-based submit button as well as the keyboard ENTER.
getdave
reviewed
Jul 14, 2023
|
And resolved the funky spinner spacing on the edit view link input: 
|
Can you help with those? 🙇♂️ |
|
Thanks for tying up all the loose ends here! 👍 👍 from me. |
Happy to help. I'll add it to our board. I might not get this is immediately though... |
|
@MaggieCabrera saw you're heading #50995; could you help get these tests updated per @getdave's comment: #52620 (review)? Should that be a separate PR/part of your existing effort — or in this one? Thanks! 🙇 |
Those are unit tests, I'm migrating the e2e tests from puppeteer to playwright, I think it's unrelated to this. I'll try to make time to have a look at this, see if I can help out. |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
|
Writing tests now... |
getdave
force-pushed
the
fix/add-back-keyboardReturn-icon-linkcontrol
branch
from
0de48ef
to
b98f214
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok @richtabor this should be good to go. |
getdave
approved these changes
Aug 8, 2023
Mind looking at the tests one more time? |
|
Oh man. They broke 🤦 Re-running as didn't look like a legit failure. Unit tests are pretty reliable between local and CI. |
getdave
force-pushed
the
fix/add-back-keyboardReturn-icon-linkcontrol
branch
from
d237448
to
2cadaff
Compare
|
This failure is not consistent. Try running with ...sometimes it fails and sometimes not. |
Also fixes spinner on the internal url input
getdave
force-pushed
the
fix/add-back-keyboardReturn-icon-linkcontrol
branch
from
2cadaff
to
804bd3c
Compare
This is the test that is failing. Looks like the mocked function is inadvertently being called twice. |
|
The bug was because a call to This indicates a wider underlying but in the code whereby the calls are not reset if the component is unmounted. We'll need to address separately. However, it should not delay this PR. I fully expect my patch for the tests to pass and for us to merge this whilst I resolve the wider problem. |
|
I had to rerun the PHP tests, but everything passed fine after that. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I couldn't find context why this was removed (if it was intentional), so here's a go at putting it back.
If we don't need the button itself, an alternate would be to employ the icon itself (which is what the block inserter search input does).
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
CleanShot.2023-07-13.at.18.16.21.mp4
After:
CleanShot.2023-07-13.at.18.11.59.mp4