Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for BlockCaption component #52535

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jul 11, 2023

Fixes #52047

What?

A README has been added for the BlockCaption component.

Why?

As requested in #52047, the README will serve as a guide for developers who may wish to contribute to Gutenberg.

How?

The README was created using the README.md for the AlignmentControl component as a guide.

Testing Instructions

Read through the latest version of the README here and share with any suggestions for improvements: https://github.com/WordPress/gutenberg/blob/3ff123444e4fe50b15af2491e9461fbe84dd5808/packages/block-editor/src/components/block-caption/README.md

@SiobhyB SiobhyB self-assigned this Jul 11, 2023
@SiobhyB SiobhyB added the [Type] Developer Documentation Documentation for developers label Jul 11, 2023
@github-actions
Copy link

Flaky tests detected in ea9ffb0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5525709687
📝 Reported issues:

@SiobhyB SiobhyB marked this pull request as ready for review July 12, 2023 12:47
@SiobhyB SiobhyB requested a review from ellatrix as a code owner July 12, 2023 12:47
@SiobhyB SiobhyB requested a review from juanmaguitar July 12, 2023 12:48
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 12, 2023

@juanmaguitar, 👋, this is ready for you to take a look :)

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 25, 2023

@juanmaguitar, do you have availability to take a look? If not, let me know and I can find another reviewer. Thanks!

@juanmaguitar
Copy link
Contributor

@SiobhyB Sorry for the late reply 🙏
The changes LGTM.
Thanks a lot for working on this documentation PR 😊

@SiobhyB SiobhyB merged commit 103ddc5 into trunk Aug 7, 2023
@SiobhyB SiobhyB deleted the rnmobile/docs/add-block-caption-readme branch August 7, 2023 10:39
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create README for "block-caption" component
2 participants