Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameter names for theme JSON related filters #52394

Closed
wants to merge 1 commit into from

Conversation

johnbillion
Copy link
Member

What?

This corrects four instances where documentation for a filter is formatted incorrectly.

Why?

This results in incorrect formatting on the developer.wordpress.org reference site.

Testing Instructions

This doesn't need functional testing, just confirmation that the updated formatting is correct.

@johnbillion
Copy link
Member Author

This has just been corrected in WordPress core in https://core.trac.wordpress.org/changeset/56157.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Flaky tests detected in a030779.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5481464323
📝 Reported issues:

@t-hamano t-hamano self-requested a review July 16, 2023 15:35
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 16, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Apr 1, 2024

Sorry for the delay in re-checking this PR. It appears that a similar change was already made by #58476.

I would like to close this PR, but appreciate your efforts!

@t-hamano t-hamano closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants