Behaviors: Extend Global Styles API to read/write behaviors config. #52370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in 5ea4b13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5599151879
|
|
Size Change: +874 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
cbravobernal
force-pushed
the
experiment/extend-behaviors-settings
branch
from
f7e1ce4
to
2ed3596
Compare
cbravobernal
added
[Type] Feature
cbravobernal
force-pushed
the
experiment/extend-behaviors-settings
branch
from
d898205
to
289a084
Compare
|
I've been taking a quick look at it and it looks great so far 👏 I have a couple of comments:
Behaviors.-.Global.Styles.mp4
|
That's weird, as I've been developing it with the case it doesn't work on your side. Not the first one 😅 |
|
I think the error is that if you set it up on block settings, it doesn't work on styles after and viceversa. |
|
Btw, this is the error I get in the console, in case it is helpful:
|
I have the default option in the block settings and still doesn't work in the global styles 🤔 |
cbravobernal
force-pushed
the
experiment/extend-behaviors-settings
branch
from
445453e
to
75f9411
Compare
13 tasks
|
I just added 3 tasks more regarding the |
|
All tests are 🟢 . Time to add some more and refactor. Feel free to comment on them! |
cbravobernal
requested review from
spacedmonkey,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
cbravobernal
force-pushed
the
experiment/extend-behaviors-settings
branch
from
b1bb22c
to
f51abe5
Compare
cbravobernal
force-pushed
the
experiment/extend-behaviors-settings
branch
from
ff34b74
to
70bf5ee
Compare
michalczaplinski
force-pushed
the
experiment/extend-behaviors-settings
branch
from
612b2e3
to
9480be5
Compare
lib/compat/wordpress-6.3/class-gutenberg-rest-global-styles-revisions-controller-6-3.php
Show resolved
Hide resolved
michalczaplinski
approved these changes
Jul 20, 2023
westonruter
added a commit
that referenced
this pull request
Jul 20, 2023
…ding-strategy * origin/trunk: (59 commits) Promisify action creator return type for WP data dispatch (#52530) [RNMobile] Add WP hook for registering non-core blocks (#52791) removes check for active preview device type to enable the fixed toolbar preference (#52770) Enforce checks against redeclaration for functions and classes (#52696) update appearance tools, (#52785) Behaviors: Extend Global Styles API to read/write behaviors config. (#52370) HeaderToolbar - Update inserterMethod meta data (#52735) add options for debugging php unit tests (#52778) Docs: Interactivity API > Getting Started Guide - minor adjustments (#52786) Footnotes: Use static closures when not using '' (#52781) Improve slug generation & matching in request utils (#52414) Open "docs" folder for the Interactivity API package and Getting Started Guide (#52462) Global Styles: Don't use named arguments for 'sprintf' (#52782) E2E utils - Update locator to hide the keyboard on iOS to pick the first element, on iPad two buttons are available and the second one makes the floating keyboard to show up (#52771) Patterns: Reinstate template parts mode spec (#52780) chore(release): publish Update changelog files Patterns: Fix empty general template parts category (#52747) Add id to pattern inserted notice to stop multiple notices stacking (#52746) Site Editor: Fix site link accessibility issues (#52744) ...
ramonjd
added a commit
that referenced
this pull request
Jul 21, 2023
- removes tests that have been ported to Core already as part of WP 6.3 - Adds tests for #52370 - Changes a private method to protected so it can be used in inherited classes
|
Hello friends! I got the test running over in #52819 |
cbravobernal
pushed a commit
that referenced
this pull request
Jul 21, 2023
- removes tests that have been ported to Core already as part of WP 6.3 - Adds tests for #52370 - Changes a private method to protected so it can be used in inherited classes
69 tasks
86 tasks
mikachan
added
Needs PHP backport
youknowriad
reviewed
Sep 15, 2023
| useGlobalSetting, | ||
| useSettingsForBlockElement, | ||
| useHasColorPanel, | ||
| useHasEffectsPanel, | ||
| useHasFiltersPanel, | ||
| useGlobalStyle, | ||
| __experimentalUseGlobalBehaviors: useGlobalBehaviors, | ||
| __experimentalBehaviorsPanel: StylesBehaviorsPanel, |
There was a problem hiding this comment.
Why are these prefixed with __experimental knowing that they are already private APIs
| const blockType = getBlockType( name ); | ||
| const blockVariations = useBlockVariations( name ); | ||
| const hasTypographyPanel = useHasTypographyPanel( settings ); | ||
| const hasColorPanel = useHasColorPanel( settings ); | ||
| const hasBehaviorsPanel = useHasBehaviorsPanel( rawSettings, name ); |
There was a problem hiding this comment.
Why is this using rawSettings instead of settings (like the other hooks).
| onChange={ setBehavior } | ||
| behaviors={ inheritedBehaviors } | ||
| blockName={ name } | ||
| ></StylesBehaviorsPanel> |
There was a problem hiding this comment.
Nit: The element could have been autoclosed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Include a Behaviors selector in the Site Editor.
Why?
Without this PR, the only way to set behaviors globally for all images was by editing
theme.json. This PR enables a selector on the site editor, understyles -> blocks -> image -> advancedthat uses Global Styles API to apply the behavior to all the images in the site.To-do list
undooption is working correctly.