Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entity cache misses for single posts due to string as recordKey #52338

Merged
merged 8 commits into from
Jul 12, 2023
Merged

Fix entity cache misses for single posts due to string as recordKey #52338

merged 8 commits into from
Jul 12, 2023

Commits on Jul 5, 2023

  1. Coerce Navigation postId to number

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6add642 View commit details
    Browse the repository at this point in the history

  2. Normalize postId argument depending on entity type

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0fdff62 View commit details
    Browse the repository at this point in the history

  3. Elminate additional resolver calls by passing correct recordKey type

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6397fd6 View commit details
    Browse the repository at this point in the history

  4. Use the correct post type in comparison

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    643cb8b View commit details
    Browse the repository at this point in the history

  5. Standardzie normalizing postId when reading postID from URL

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    457ba2d View commit details
    Browse the repository at this point in the history

  6. Normalize postId for a Page

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    37560fb View commit details
    Browse the repository at this point in the history

  7. Extract common util

    @getdave
    getdave committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9d70104 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Apply numericID test instead of maintaining list of recordKey types

    @getdave
    getdave committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7fe8755 View commit details
    Browse the repository at this point in the history