Navigation block: Add notice on reduced accessibility #52251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Focus] Accessibility (a11y)
|
Size Change: +176 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Jul 4, 2023
|
Ok. I made the screen reader notice assertive and it doesn't trigger on the initial render. Let me know if that helps 🙂 |
|
Flaky tests detected in 5e15a923599b353eb8f4fbb5b6d2dedec148189b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5456756041
|
alexstine
reviewed
Jul 4, 2023
There was a problem hiding this comment.
@luisherranz Can you pass the entire notice content variable into speak()? Screen readers should get the full context. Also, I think we can drop assertive off this notice. Through testing, I think it is okay that the screen reader announces the checkbox state and then the notice. Sometimes assertive is needed depending on how dynamic the notice is so we catch users attention before they navigate elsewhere canceling out the notice. Sorry, these things can be tricky to get right. Almost there.
Oh, absolutely. I did it because I saw that the color contrast spoken notice was a reduced version, so I thought spoken notices shouldn't be too long.
Sure, no problem 🙂 |
luisherranz
force-pushed
the
add/navigation-block-notice-on-reduced-accessibility
branch
from
54399f0
to
97629b8
Compare
Generally, yes. However, users can always press control if they do not want to hear more. Where if they do want to hear more, they will have to navigate to the notice, what they already heard, and then the rest of the notice. It's a tricky balance at times. |
|
Cool. Thanks for the review, Alex! |
luisherranz
deleted the
add/navigation-block-notice-on-reduced-accessibility
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51226.
Why?
Because when both the
showSubmenuIcons("Show arrows" in the UI) andopenOnClickoptions are false, the accessibility is reduced, and after some discussion, the decision was to add a warning when both of those options are false.How?
Just use the component and approach as the one used in the Color panel for the low contrast warning.
I have one question: should the screen reader notice be triggered each time there is a full refresh if those options are selected, or only after the user has changed them?
I'm following what I saw for other notices, but it feels a bit weird to hear that notice each time you refresh, so I wonder what's the usual behavior here.
Testing Instructions
Screenshots or screencast