Navigation: Fix sidebar title #52167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d3a9b8c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5455027662
|
scruffian
force-pushed
the
fix/navigation-title
branch
from
2e2f9b4
to
d3a9b8c
Compare
|
This introduces the same error you fixed recently - #51589. I can confirm with the Console theme but not with TT3; not sure what the difference is. I noticed while checking the e2e test failure for Navigation block tests. |
glendaviesnz
added a commit
that referenced
this pull request
Jul 5, 2023
This reverts commit ea6b5a1.
|
I have a fix up for this here. @scruffian |
We shouldn't have this variance. Makes me think something is wrong in one of the responses from REST based on |
|
I can't replicate the problem I was having now... |
|
@getdave, @scruffian, did you get a chance to narrow down the cause of the problem? I saw this report #50557 yesterday, and I think it's related to this behavior. |
|
I haven't had time to narrow this down. To do this we need to:
I think it's likely to do with the I believe instead of accessing title directly we should call |
|
Thanks, Dave! |
|
How about this? #52635 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the title in the Navigation section of Patterns to use the name of the navigation itself.
Why?
We should show the actual name of the navigation.
How?
Just reference the title prop directly.
Testing Instructions