-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Command center]: Add preferences and keyboard shortcuts commands #51862
Conversation
Size Change: +966 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
46a750c
to
63ea335
Compare
Flaky tests detected in 49786fd9cbdd08c46ab8327302d8ce2512c72983. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5378726782
|
5d878a6
to
1b13b8c
Compare
1b13b8c
to
3f97290
Compare
…1862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
I just cherry-picked this PR to the release/16.1 branch to get it included in the next release: 0ab057c |
…1862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
I just cherry-picked this PR to the add/pre-beta1-bugfixes branch to get it included in the next release: bdc33c9 |
* Restore sidebar in focus mode on Pattern click through in Browse Mode Library (#51897) Brings back #51492 * [Command center]: Add preferences and keyboard shortcuts commands (#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels * [Site Editor]: Fix `library` command path (#51837) * Updating social link attributes (#51997) * Try: Update template titles (#51428) * Update template titles * Fix typo Co-authored-by: Alex Stine <[email protected]> * Revert Index rename * "front page" -> "homepage" * Update 404 Page make more sense given the template appears in the Pages panel too. * Front Page * home title + description * Revert Home name change, and move compat files * separate code for wp versions * update tests --------- Co-authored-by: Alex Stine <[email protected]> Co-authored-by: ntsekouras <[email protected]> * Update text color (#51965) * Modal: Add small top padding to the content so that avoid cutting off the visible outline when hovering items (#51829) * Site Editor: Fix focus cutoff in add template modal * Add padding-top to the modal content * Remove unnecessary padding-top * Remove unnecessary padding-top * Update changelog * Revert top padding from block patterns list * Revert top padding from block patterns list * Remove unnecessary changes * Remove unnecessary changes * Add CSS inline comment * Change padding metrics * Rest API: rename navigation fallback classes from WP_ to Gutenberg_ (#51959) * The `WP_REST_Navigation_Fallback_Controller` class has been committed to core and therefore results in a naming conflict and unit test failures. Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`. But we can conditionally load the file instead. * Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Block_Menu_Converter Load WP_REST_Navigation_Fallback_Controller dependencies in load.php * Renamed all 6.3 classes to have the Gutenberg_ prefix. This should avoid compat errors and hopefully some confusion later. * Also rename test files for completeness * Updated deprecation notices to refer to Gutenberg classes * Fix phpunit failures (#51950) * Fix phpunit failures * Add comment * Update comment with actual reason this fix works --------- Co-authored-by: Dave Smith <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Alex Stine <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
…rdPress#51862) * [Command center]: Add preferences and keyboard shortcuts commands * update labels
What?
Part of: #51502
This PR adds the following commands to both site and post editor:
How
In order to open the modals programmatically I had to keep this information in the edit site store, so I added the respective selectors, actions, etc.. In post editor we already had this information in store
Testing Instructions
Options
vertical ellipsis menu.Notes
There is currently a bug in. the logic of site editor commands in
edit mode
, but it's going to be fixed in this PR by @youknowriad .