Block Theme Previews: rename GET variable and prepare for core compat #51738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
force-pushed
the
theme-previews-variable-rename
branch
2 times, most recently
from
053c267 to
a34481c
Compare
Co-authored-by: Andrei Draganescu <[email protected]>
MaggieCabrera
force-pushed
the
theme-previews-variable-rename
branch
from
a34481c to
fc54791
Compare
scruffian
added
the
[Feature] Themes
|
Size Change: +60 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
MaggieCabrera
requested review from
spacedmonkey,
nerrad and
mmtr
as code owners
scruffian
approved these changes
Jun 21, 2023
|
Flaky tests detected in 6388f62. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5335529395
|
|
Let's bring this in. since it's needed for 6.3, the middleware was using the GB variable |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…WordPress#51738) * renamed get variable and loaded actions and filters conditionally Co-authored-by: Andrei Draganescu <[email protected]> * removed test code * linter --------- Co-authored-by: Andrei Draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When we backport the block theme previews to WordPress Core, we need to update the URL get parameters to
wp_theme_previewinstead ogutenberg_theme_preview. We should make the same change to Gutenberg so that we use the same param in both places. See WordPress/wordpress-develop#4627.Why?
So that we have the same URL parameter in both places.
Users that decide to stay on an older version of core after 6.3 but do update the GB plugin will lose access to the theme preview functionality unless we build support for both parameters. Since this hasn't been long in the plugin, I don't think there's much reason to maintain both, so the core version is preferred. Happy to hear any opinions against this decision.
How?
Just rename the parameter.
Testing Instructions