Edit Site: Remove first loading spinner #51736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
youknowriad,
mtias,
jsnajdr,
jameskoster,
jasmussen and
flootr
|
Noting that initially, this loader was also something that used to fill the canvas and not the entire screen, something have changed in the meantime. I think this PR is good with this new reality, it would be cool to figure out if we can "preload" the requirements of this spinner (if it's not already the case) that way we avoid that loader entirely. |
youknowriad
approved these changes
Jun 21, 2023
|
Size Change: +9 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR suggests removing the first loading spinner as discussed in #51709 (comment)
Why?
In #51709 we're polishing the current loading experience by altering it to resemble the canvas color scheme. However, the initial loading spinner conflicts with that, so I think it's better if we just remove it.
How?
We're no longer displaying the additional spinner.
Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
Before (with an additional loading spinner in the beginning):
Screen.Recording.2023-06-21.at.13.57.43.mov
After (with no additional loading spinner in the beginning)
Screen.Recording.2023-06-21.at.13.56.49.mov