Link Format: Don't return focus on the selected text 'onFocusOutside' #51684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Inserter
|
Size Change: +19 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Jun 20, 2023
|
Thank you, @getdave!
Does this fail occasionally, or do I need to adjust anything in the tests?
That would be a considerable improvement. Playwright DX is fantastic! |
I think it will need a tab stop count adjustment. The tests rely way too much on tabbing order. |
Mamaduka
force-pushed
the
fix/link-format-popover-focus
branch
from
649b31a to
eadf836
Compare
|
I adjusted the e2e test. The previous behavior relied on focus return behavior. |
|
Flaky tests detected in eadf836. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5321172958
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…WordPress#51684) * Link Format: Don't return focus on the selected text 'onFocusOutside' * Update e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51646.
Do not return focus to the selected text when the Link format inline popover is closed by focusing outside. Fixes a bug with the main block inserter closing because of focus change.
Why?
The
onFocusOutsideevent can be interpreted as the user's intention to move focus to another element.How?
stopAddingLinkto manage focus returns.onFocusOutsidehandler for the popover.Testing Instructions
Screenshots or screencast
CleanShot.2023-06-20.at.12.25.25.mp4