Page details: Fix displaying slugs with non-latin characters #51679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Feature] Site Editor
Mamaduka
reviewed
Jun 20, 2023
Comment on lines
93
to
95
| { decodeURI( | ||
| record.link.replace( /^(https?:\/\/)?/, '' ) | ||
| ) } |
There was a problem hiding this comment.
I believe the core uses the safeDecodeURIComponent from the url package, in other places for similar fixes. We can also replace the regex here with filterURLForDisplay.
{ filterURLForDisplay( safeDecodeURIComponent( record.link ) ) }Edit: I found my PR that fixes a similar bug in post editor - #42930.
There was a problem hiding this comment.
Thank you, I did not know these existed.
Mamaduka
reviewed
Jun 20, 2023
| value: <Truncate numberOfLines={ 1 }>{ page.slug }</Truncate>, | ||
| value: ( | ||
| <Truncate numberOfLines={ 1 }> | ||
| { decodeURI( page.slug ) } |
There was a problem hiding this comment.
Same here, but just safeDecodeURIComponent.
|
Size Change: +12 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a58045d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5319665259
|
Mamaduka
approved these changes
Jun 20, 2023
t-hamano
approved these changes
Jun 20, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ss#51679) * Page details: Fix displaying slug with non-latin characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If a page has a title and slug with non-latin characters, the page details show them as encoded:
The Slug /επίπεδο-2/ shows as %ce%b5%cf%80%ce%af%cf%80%ce%b5%ce%b4%ce%bf-2.
This PR decodes the visual presentation of the slug in two places in the page details:
The page link at the top below the page title, and the page slug item that is further down the list.
Closes #51676
Why?
The text was not displayed correctly.
How?
Decodes the URI and slug.
Testing Instructions
Привет, мирTesting Instructions for Keyboard
Привет, мирScreenshots or screencast
After:
