[Query Loop]: Properly initialize and update perPage when we inherit from global query
#51641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from global query
ntsekouras
added
[Type] Bug
This was referenced Jun 19, 2023
|
Size Change: +54 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Not a code review
The correct number of posts is shown in the editor (minus the sticky post, which is a separate issue).
When switching "Inherit query from template" on and then off again, the items per page setting in the block toolbar is reset to the value that is added under Settings > Reading.
|
Flaky tests detected in 37de57e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5310338117
|
Mamaduka
approved these changes
Jun 19, 2023
|
Thanks for fixing this so quickly 🙇 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…t from global query (WordPress#51641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There are cases where themes are using
Query Loopblocks that inherit from global query, but have also set the value of theirperPageattribute(example 2023 theme). This has no effect in front-end, but at the editor side the logic preserves that value, that is not in sync with the respective reading setting.This PR always prioritizes the reading setting if we
inheritand also properly updates the value if the reading setting is updated. This will be needed for #51223 too.Testing Instructions
per_pagereading setting is honored