Migrate block hierarchy navigation tests to Playwright #51517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
[Type] Automated Testing
Mamaduka
commented
Jun 15, 2023
| await pageUtils.pressKeys( 'ctrl+`' ); | ||
|
|
||
| // Navigate to the block settings sidebar and tweak the column count. | ||
| await pageUtils.pressKeys( 'Tab', { times: 5 } ); |
There was a problem hiding this comment.
The original test used do...while here, but I switched to a more straightforward approach. The test already relied on the "key * times" press in other areas.
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 15, 2023
test/e2e/specs/editor/various/block-hierarchy-navigation.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
TBH I'm not sure how is this file different than the list-view spec? 😅
There was a problem hiding this comment.
I believe the list-view spec focuses or should focus on the List View component functionality, while this tests keyboard navigation around the editor and uses List View.
There was a problem hiding this comment.
I had no idea we had this test before adding some new ones in the list-view spec, so possibly I have slipped in some tests that really should've been here 😅 .
|
Flaky tests detected in a7b8616. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5274886483
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Migrate block hierarchy navigation tests to Playwright * Remove old test file * Remove snapshot * Use locator fill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Closes #48554.
Closes #47001.
Closes #50093.
PR migrates flaky block hierarchy navigation tests to Playwright.
Why?
The flaky test report for the
should navigate using the list view sidebarissue has been updated 280+ times.Testing Instructions