Fix document title back and shortcut color contrast. #51442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
jameskoster
reviewed
Jun 13, 2023
| text-align: right; | ||
| .edit-site-document-actions__shortcut, | ||
| .edit-site-document-actions__back { | ||
| color: darken($gray-700, 3%); // Darken the secondary color to meet requirements against a gray background. |
There was a problem hiding this comment.
Could we use gray-800 rather than a 'custom' color? 🤔
There was a problem hiding this comment.
We can, yes, though it's slightly dark innit? That was the intent by just darkening a little bit.
There was a problem hiding this comment.
For me it's worth that potential trade-off to avoid deviating from the scale. I don't actually mind the darkness:
It's just a nitpick though :)
jameskoster
added
the
Needs Figma Update
|
Flaky tests detected in ea73776. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5252911376
|
jameskoster
approved these changes
Jun 13, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Fix wayfinder back and shortcut color contrast. * gray-800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The document title element in the site editor had too low contrast for the shortcut indication. This PR fixes it:
The new contrast is:
This behavior applies to both back button and shortcut tip.