Make sure post content always has correct layout. #51431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ndiego
approved these changes
Jun 13, 2023
andrewserong
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks for fixing this up!
✅ Allows the default layout to be applied to fix the reported bug
✅ Classic themes appear to be unaffected as they still use their rules from classic.css
✅ left/center/right constrained alignments still work as expected
✅ Previous fixes for wide alignment of the post content block still work as expected
LGTM! ✨
|
Thanks for the reviews folks! |
|
Heya @ndiego |
|
Sure thing, I'll prepare RC5 in an hour or so. 💪 |
ndiego
added
the
Backport to Gutenberg RC
|
Thank you very much Nick! |
ndiego
pushed a commit
that referenced
this pull request
Jun 13, 2023
ndiego
removed
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/16.0 branch to get it included in the next release: 54a807f |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
youknowriad
reviewed
Nov 30, 2023
| layoutDefinitions={ | ||
| globalLayoutSettings?.definitions | ||
| } | ||
| /> |
There was a problem hiding this comment.
Why do we have this component than render "blockListLayout" styles and just a few lines down here the following code
<LayoutStyle
layout={ postContentLayout }
css={ postContentLayoutStyles }
/>
that use the CSS prop to render some styles. Are these styles different? They feel like the same layout styles. What is the purpose of each one of these calls?
There was a problem hiding this comment.
I'm no longer sure because this code has gone through a few changes 😅 but I think the first instance adds the initial computed layout for classic and block themes, and the second one only applies to block themes and adds any changes to Post Content if the template is edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51371 by separating out the default styles for Post Content and Post Title in the post editor. Post Title doesn't have layout attributes, so it should be provided with a fallback style. Post Content does have layout, so it should always respect its layout settings.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast