Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pattern directory categories endpoint #51340

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

ntsekouras
Copy link
Contributor

What?

This PR removes the pattern directory categories endpoint that is not currently used. It was added as preparatory work for #45237, but it seems we might not pursue this kind of integration at this moment, with all the pattern work going on right now.

It would be easy enough to bring it back if we need to.

Testing Instructions

Everything should work as before, as it's not used anywhere.

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 8, 2023
@ntsekouras ntsekouras requested review from mcsf and Mamaduka June 8, 2023 13:06
@ntsekouras ntsekouras requested a review from spacedmonkey as a code owner June 8, 2023 13:06
@ntsekouras ntsekouras self-assigned this Jun 8, 2023
@ntsekouras ntsekouras changed the title Remove pattern directories endpoint Remove pattern directory categories endpoint Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Flaky tests detected in 886b98b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5241509920
📝 Reported issues:

Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the test failures are unrelated, LGTM.

@ntsekouras ntsekouras force-pushed the remove/pattern-directory-categories-endpoint branch from b50ec8d to bfa1374 Compare June 11, 2023 14:36
@ntsekouras ntsekouras merged commit 797098f into trunk Jun 12, 2023
@ntsekouras ntsekouras deleted the remove/pattern-directory-categories-endpoint branch June 12, 2023 09:56
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 12, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
* Remove pattern directories endpoint

* fix init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants