Try providing a non-zero value for client width in image editor. #51285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
Size Change: +122 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
If I read this fix correctly, then it's a good improvement and just needs a code sanity check. Images should never collapse into black holes. Speaking of, I vaguely recall a similar issue with some embeds, notably responsive video embeds, which we've currently patched up with a min-width bandaid. Would a fix like this work there as well? |
apeatling
approved these changes
Jun 7, 2023
andrewserong
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Nice fix, this is testing great for me, too!
✅ Cropping tools work correctly on image block in flow content
✅ Cropping tools work correctly on image block within a Gallery block
✅ Cropping tools work correctly on image block within a Row block
✅ Cropping tools work correctly on image block with custom width set
2023-06-08.09.08.34.mp4
Looks good to me, and if we run into any issues, it'll be an easy revert! LGTM ✨
andrewserong
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Nice fix, this is testing great for me, too!
✅ Cropping tools work correctly on image block in flow content
✅ Cropping tools work correctly on image block within a Gallery block
✅ Cropping tools work correctly on image block within a Row block
✅ Cropping tools work correctly on image block with custom width set
2023-06-08.09.08.34.mp4
Looks good to me, and if we run into any issues, it'll be an easy revert! LGTM ✨
Co-authored-by: Andrew Serong <[email protected]>
Hmm the Video block doesn't use the cropping library or the width calculations that were causing this issue in the Image block, so it's unlikely. |
|
Thanks for reviewing and testing, folks! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…dPress#51285) * Try removing align value from clientWidth hook * Try providing a non-zero value for client width. * Remove empty line. * Fix typo Co-authored-by: Andrew Serong <[email protected]> --------- Co-authored-by: Andrew Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51250.
The initial calculation from useClientWidth hook is sometimes zero, and we don't want it to recalculate every time image width changes because it can go into an infinite loop. The problem is that clientWidth provides the dimensions for the image editor so, if that value is zero, the image editor is 0px wide.
I've tried to fix that by instead passing the current width of the image to the image editor, with client width as a fallback in case that's undefined. I've tested with images inside and outside of flex and non-flex containers, and with different alignments, and it seems to work fine in all cases, but would be good to test further!
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast