-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block manager: Display a 'Reset' button when blocks are hidden to quickly enable all #51200
Block manager: Display a 'Reset' button when blocks are hidden to quickly enable all #51200
Conversation
Adding the design review tag to this since I think this could be better as a link. |
Co-authored-by: Daniel Bachhuber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 👍
@danielbachhuber Should I wait for design feedback? Is @javierarce the right person to ping here? |
Thanks for the ping @apeatling. This little UI is a bit rough isn't it! Outside of a total redesign, I think my main suggestion here would be to change the button label to something a bit simpler. "Reset" might work? |
@jameskoster I updated with the changes you proposed. However, for some reason the changes don't appear here. |
@kozer That's weird... Can you create a new pull request? I wouldn't trust merging this one if all of the commits aren't shown. |
@danielbachhuber I'll do that first thing tomorrow |
@kozer Actually, it looks like there's an active GitHub incident: https://www.githubstatus.com/incidents/1g1gkh0qpyvs Hopefully it will be addressed by the time you're online tomorrow. |
Enable all - Reset What do we in general do in Gutenberg? Is it Reset that we use to go back to default or something similar? If I wanted to show all the blocks I would make it really clear that clicking a specific text link will show all the blocks. Be it the words are "Enable all" or "Reset" What about something like "Enable all to show all the blocks" or "Reset to show all the blocks" or something else that just gives the explanation of what happens. |
@danielbachhuber everything is showing as expected now. There are pending reviews, and I cannot merge. How I can make it to go through? |
@kozer One last change, please. You can't merge because you don't have permissions to do. I've pinged you in Slack with some explanation. |
@jameskoster @WordPress/gutenberg-design Should we remove the italization while we're here? CurrentProposed |
Looks much better. +1 to removing the italic. |
I think the whole element is ripe for an update, but was hesitant to make any specific suggestions and risk scope creep on the PR. That said, I don't imagine any such redesign would make use of italic text, so if we did want to remove it here that would be fine imo 👍 |
@jameskoster Sounds good, thanks! |
@danielbachhuber , I removed the italics from the text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well 👍
I updated the pull request description with the most recent screenshot.
…ckly enable all (WordPress#51200) Co-authored-by: Daniel Bachhuber <[email protected]>
https://playground.wordpress.net/?gutenberg-pr=51200
Related to #50015
What?
It adds a "Reset" button in order to easily show all the hidden blocks in the Preferences section.
Why?
Right now, when there are many hidden blocks, the user must:
The first one is time-consuming, and the second one is a bit tricky, as it's not particularly obvious to the end user.
Adding a new button specific to that use case will make things easier for the end user.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast