Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block manager: Display a 'Reset' button when blocks are hidden to quickly enable all #51200

Merged

Conversation

kozer
Copy link
Contributor

@kozer kozer commented Jun 2, 2023

https://playground.wordpress.net/?gutenberg-pr=51200
Related to #50015

What?

It adds a "Reset" button in order to easily show all the hidden blocks in the Preferences section.

Why?

Right now, when there are many hidden blocks, the user must:

  • Enable them again one by one
  • Enable them in bulk by clicking on the category of each block

The first one is time-consuming, and the second one is a bit tricky, as it's not particularly obvious to the end user.

Adding a new button specific to that use case will make things easier for the end user.

Testing Instructions

  1. Edit a page
  2. Navigate to "Preferences" in the top right corner
  3. Make sure that you uncheck some blocks, after visiting "Panels" menu in the sidebar.
  4. Ensure that you see an "Reset" button.
  5. Ensure that when you press it, all blocks are checked again.

Testing Instructions for Keyboard

Screenshots or screencast

image

@apeatling
Copy link
Contributor

Adding the design review tag to this since I think this could be better as a link.

@apeatling apeatling added the Needs Design Feedback Needs general design feedback. label Jun 6, 2023
@kozer kozer requested a review from danielbachhuber June 7, 2023 10:05
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@kozer
Copy link
Contributor Author

kozer commented Jun 7, 2023

@danielbachhuber Should I wait for design feedback? Is @javierarce the right person to ping here?
Also, it seems that React Native E2E Tests are failing. How I can re-run them? Navigating to the details of the failed job, doesn't give me any way to run it again.
Thanks!

@jameskoster
Copy link
Contributor

Thanks for the ping @apeatling.

This little UI is a bit rough isn't it! Outside of a total redesign, I think my main suggestion here would be to change the button label to something a bit simpler. "Reset" might work?

Screenshot 2023-06-07 at 17 13 13

@kozer
Copy link
Contributor Author

kozer commented Jun 7, 2023

@jameskoster I updated with the changes you proposed. However, for some reason the changes don't appear here.
But they are perfectly displayed here:
trunk...kozer:gutenberg:add/block_manager_enable_all_button

@danielbachhuber
Copy link
Member

However, for some reason the changes don't appear here.
But they are perfectly displayed here:

@kozer That's weird...

Can you create a new pull request? I wouldn't trust merging this one if all of the commits aren't shown.

@kozer
Copy link
Contributor Author

kozer commented Jun 7, 2023

@danielbachhuber I'll do that first thing tomorrow

@danielbachhuber
Copy link
Member

@kozer Actually, it looks like there's an active GitHub incident: https://www.githubstatus.com/incidents/1g1gkh0qpyvs

Hopefully it will be addressed by the time you're online tomorrow.

@paaljoachim
Copy link
Contributor

Enable all - Reset

What do we in general do in Gutenberg? Is it Reset that we use to go back to default or something similar?

If I wanted to show all the blocks I would make it really clear that clicking a specific text link will show all the blocks. Be it the words are "Enable all" or "Reset"

What about something like "Enable all to show all the blocks" or "Reset to show all the blocks" or something else that just gives the explanation of what happens.

@kozer
Copy link
Contributor Author

kozer commented Jun 8, 2023

@danielbachhuber everything is showing as expected now. There are pending reviews, and I cannot merge. How I can make it to go through?

@danielbachhuber
Copy link
Member

everything is showing as expected now. There are pending reviews, and I cannot merge. How I can make it to go through?

@kozer One last change, please. You can't merge because you don't have permissions to do. I've pinged you in Slack with some explanation.

@danielbachhuber
Copy link
Member

@jameskoster @WordPress/gutenberg-design Should we remove the italization while we're here?

Current

image

Proposed

image

@danielbachhuber danielbachhuber added the [Type] Enhancement A suggestion for improvement. label Jun 8, 2023
@danielbachhuber danielbachhuber added the [Package] Preferences /packages/preferences label Jun 8, 2023
@apeatling
Copy link
Contributor

Looks much better. +1 to removing the italic.

@jameskoster
Copy link
Contributor

I think the whole element is ripe for an update, but was hesitant to make any specific suggestions and risk scope creep on the PR.

That said, I don't imagine any such redesign would make use of italic text, so if we did want to remove it here that would be fine imo 👍

@danielbachhuber
Copy link
Member

@jameskoster Sounds good, thanks!

@kozer kozer requested a review from danielbachhuber June 12, 2023 07:16
@kozer
Copy link
Contributor Author

kozer commented Jun 12, 2023

@danielbachhuber , I removed the italics from the text.

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well 👍

I updated the pull request description with the most recent screenshot.

@danielbachhuber danielbachhuber changed the title Block manager: Add an enable all button for hidden blocks Block manager: Display a 'Reset' button when blocks are hidden to quickly enable all Jun 12, 2023
@danielbachhuber danielbachhuber merged commit 1ae8864 into WordPress:trunk Jun 12, 2023
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 12, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs User Documentation Needs new user documentation [Package] Preferences /packages/preferences [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants