Add reset button to color control #50989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: +183 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add inline reset button only shown on hover/focus to color control. Also unify the name from "clear" to "reset".
Note that gradient color doesn't have a reset button to match the original implementation in the dropdown. I don't know if it's a deliberate choice or an oversight?
Why?
Close #41866
How?
Add a button and tweak CSS.
Testing Instructions
Testing Instructions for Keyboard
[type]is the property of the color, e.g. "Text" or "Background".Screenshots or screencast
Kapture.2023-05-26.at.15.13.45.mp4