Navigation block: Remove browser default padding from the two submenu buttons #50943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Navigation
|
Size Change: +58 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d0d69b7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6156017308
|
jasmussen
approved these changes
Jul 24, 2023
|
Like visual regression tests? |
mikachan
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
This fixes the mismatch in spacing for me 🎉
I'm still seeing a slight difference in positioning between the buttons and the anchor tags when toggling the "Open on click" option, which would be nice to fix too, but I don't think it should hold up this PR:
Screen.Recording.2023-08-18.at.15.18.51.mov
mikachan
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When the Navigation Block: "Open on click" setting is used, the submenu button has some extra padding from browser styles. This padding means that in vertical menus, the button text on the submenu parent item does not align with the other links.
This PR sets the padding to 0.
Closes
#50722
Why?
To make the menu items align better.
How?
The implementation of the sub menu toggle button is a little bit different in the page list block and in the "regular" sub menu of navigation links. So there are two style changes, one for each button.
Testing Instructions
Screenshots or screencast
I am using a classic theme that does not add any extra CSS.
To clarify, the "Sample page" text is the page list submenu parent item, and
"preformatted" is a post title, it is the regular submenu parent item.
Before:
After:
