Iframe: use src instead of srcDoc #50875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +52 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Jul 5, 2023
By making font asset files URLs absolute instead of relative, this ensures each font asset file does properly relate to the actual location of the files. See WordPress/gutenberg#50875. Props ironprogrammer, antonvlasenko, ndiego, shuvo247, robinwpdeveloper. Fixes #58672. Built from https://develop.svn.wordpress.org/trunk@56139 git-svn-id: http://core.svn.wordpress.org/trunk@55651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jul 5, 2023
By making font asset files URLs absolute instead of relative, this ensures each font asset file does properly relate to the actual location of the files. See WordPress/gutenberg#50875. Props ironprogrammer, antonvlasenko, ndiego, shuvo247, robinwpdeveloper. Fixes #58672. Built from https://develop.svn.wordpress.org/trunk@56139 git-svn-id: https://core.svn.wordpress.org/trunk@55651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
The problem with srcDoc is that window.location is not filled, so relative hash links will trigger a navigation change and reload the page. It would also remove the need for a hack in WP playground.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast