-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Enqueue the registered assets (#50185)" #50537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
revert/temp-fix-for-editor-assets
branch
2 times, most recently
from
May 24, 2023 08:49
2e62ff5
to
2b7fc8e
Compare
oandregal
force-pushed
the
revert/temp-fix-for-editor-assets
branch
from
May 24, 2023 10:33
2b7fc8e
to
fc18cd9
Compare
oandregal
requested review from
spacedmonkey,
ntwb,
nerrad and
ajitbohra
as code owners
May 24, 2023 10:33
ntsekouras
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] E2E Tests
/packages/e2e-tests
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50246
What?
This PR reverts #50185
Why?
That was a temporary fix to get the
iframed-inline-styles
e2e test passing.The root issue was caused by a core change that is being reverted at WordPress/wordpress-develop#4498. As soon as it is, we can revert this as well.
How?
Revert the temporary fix.
Testing Instructions
The
iframed-inline-styles
e2e test should pass.