Fix docker-compose options for the phpunit and composer environments #50406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Bug
noahtallen
commented
May 5, 2023
| ! isTTY ? '--no-TTY' : '', | ||
| '-w', | ||
| envCwd, | ||
| useRun ? '--rm' : '', |
There was a problem hiding this comment.
I tested that empty string is acceptable when running exec (npx wp-env run cli ls)
ObliviousHarmony
approved these changes
May 5, 2023
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
closing in favor of #50408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is kind of a partial revert of #50007 -- it restores the previous "docker-compose run" behavior for the phpunit and composer environments, which are not long-running envs.
This also fixes the root path of the composer environment -- the root cwd was changed in #49908 to the WordPress root which is different from what composer uses.
Why?
It's not possible to use these environments correctly on trunk.
How?
See above
Testing Instructions
local testing / tbd