Fix accessibility of the Classic block modal dialog #50384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Note: of course, there are edge cases with very small viewports and especially very short heights. In these edge cases the Cancel/Save buttons may not be fully usable but the classic editor wouldn't be that usable as well, as the edit area becomes too small to be used. I'd say this is more a limitation of the modal dialog itself. |
|
Size Change: +284 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Before:
After:
|
aristath
reviewed
May 10, 2023
alexstine
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50161
What?
FIxes the accessibility of the Classic block modal dialog. Also improves labeling and design consistency.
Why?
The modal dialog misses some important accessibility features. Keyboard interaction is broken, labeling is incorrect, etc.
Also improves design consistency with other modal dialogs.
How?
useFocusOutsidehook.tertiaryfor consistency.Testing Instructions
aria-labelledbyattribute that points to the dialog heading.Screenshot of a template toolbar:
tertiarybutton, with blue text, like in other dialogs e,g, the Block Lock one.Testing Instructions for Keyboard
See above.
Screenshots or screencast