Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site logo preview image size with long filenames #50242

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix site logo preview image size with long filenames #50242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
285ef44
Fix site logo preview image size with long filenames
ntsekouras May 2, 2023
8af83e4
hardcode width value
ntsekouras May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-library/src/site-logo/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@

img {
width: $grid-unit-50 * 0.5;
min-width: $grid-unit-50 * 0.5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a separate variable for this size. There's $radio-input-size, but it might be worth either creating another, or renaming that one so we have a single size for this. Can even be a new $grid-unit-25. But short of doing that, maybe it's fine to just type out 20px?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust your judgement about this and will update the code. If the new designs(or some current ones are using the 20px value, I can create a new var. Alternatively I can hardcode the 20px for now.

aspect-ratio: 1;
box-shadow: inset 0 0 0 1px rgba(0, 0, 0, 0.2);
border-radius: 50% !important;
Expand Down