chore: update memize to v2

[johnhooks]

What?

Update memize to the latest version.

Why?

Typing @wordpress/blocks and @wordpress/block-editor depend on a change to how memize exports it's types. There are also improvements to the generic function argument of memize that will facilitate more complete typing.

• feature: add TypeScript types to the blocks package #48604
• Publish block editor build types #49969

Testing Instructions

There are two failing tests in packages/edit-site/src/store/test/utils.js which rely on an internal testing API of memize, getCache(). It is no longer included in the published version. Either the tests need to be removed or tested another way (temporally they are commented out).

Notes

An update to how v2 of memize defines its exports being worked on in aduth/memize#11, it will need to be published before the unit tests will pass.

[johnhooks]

@gziolo what is the right way to update a dependency version within the setup of this monorepo. I'm getting very different results between my local computer and the CI. I think it has to do with the lock file.

What I did

• Update the version of memize in the package.json files of all the packages that declare it as a dependency.
• Run npm install
• For some reason memize isn't being installed and is actually being removed from the package-lock.json

Edit:

Sorry I made some mistake, it's all correct now I believe.

Edit 2:

No there is still some issue, what is the correct version of npm to use? I'm currently using what is installed with Node v14.21.3 which is npm v6.14.18

[gziolo]

memize needs to be updated in the top-level node_modules. The simplest way is to run npm install [email protected] in the project so the lock file gets correctly updated. Once that happens, it needs to be removed from the package.json and another npm install run will clean up everything.

[gziolo]

The lock file is still incorrect. It doesn’t contain the latest version of memize in all places.

I tried to apply a patch from this branch locally, but I ran into the issue when using the latest trunk:

[johnhooks]

@gziolo I will try reverting the lockfile to the original and using your trick

[dcalhoun]

If capturing correct lock file changes while upgrading memize continues to be an issue, removing and re-adding the dependency may also help.

[gziolo]

This looks great, thank you @johnhooks for bringing it to the finish line!

[johnhooks]

@gziolo there were two commented out tests that used an internal api of memize that was no longer exported, I hadn't received feedback on what to do with them. I think they could be safely removed because they are effectively testing the functionality of memize. Should I do another PR that completely removes the two tests, or should we write the tests differently?

https://github.com/johnhooks/gutenberg/blob/6c452bcaa43db5938d8902d44bd4bdf2081dc5d2/packages/edit-site/src/store/test/utils.js#L147-L155

https://github.com/johnhooks/gutenberg/blob/6c452bcaa43db5938d8902d44bd4bdf2081dc5d2/packages/edit-site/src/store/test/utils.js#L181-L188

[gziolo]

Should I do another PR that completely removes the two tests, or should we write the tests differently?

I missed that, along with other changes. Another PR with the cleanup would be more than welcomed 😄