Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid typography: use logarithmic scale factor to calculate a min font size #49707

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Fluid typography: use logarithmic scale factor to calculate a min font size #49707

merged 10 commits into from
Apr 20, 2023

Commits on Apr 18, 2023

  1. Fluid Typography: Try adding a ceiling to the calculated minimum font… 

    … size
    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    be6575d View commit details
    Browse the repository at this point in the history

  2. Update existing tests, add a couple of additional tests to cover the … 

    …ceiling on the minimum font size
    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    19579ca View commit details
    Browse the repository at this point in the history

  3. Add test to ensure ceiling is skipped when min font size is provided

    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e00268d View commit details
    Browse the repository at this point in the history

  4. Fix whitespace issue

    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ce78698 View commit details
    Browse the repository at this point in the history

  5. Try reducing the default minimum viewport width

    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a710eca View commit details
    Browse the repository at this point in the history

  6. In this commit, we use a logarithmic scale factor to calculate a mini… 

    …mum font scale that tapers out as the font size increases.

The calculation is only performed where there no min font size is passed to the fluid font size methods.
The min font scale factor is constrained by min and max values.
Tests are updated to reflect the new clamp values.
Docs are updated to reflect API change in JS function (removing minimumFontSizeFactor arg)
    @ramonjd
    ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    763b269 View commit details
    Browse the repository at this point in the history

  7. Fix lint and JS tests

    @ramonjd
    ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    574656f View commit details
    Browse the repository at this point in the history

  8. EL LINTO DEL DIABLO!

    @ramonjd
    ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d263ff8 View commit details
    Browse the repository at this point in the history

  9. Updating typography props test

    @ramonjd
    ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    345233b View commit details
    Browse the repository at this point in the history

  10. Switching to log base 2

    @ramonjd
    ramonjd committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f5630e1 View commit details
    Browse the repository at this point in the history