Use the keyboard shortcuts package for the command center #49680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
jasmussen
approved these changes
Apr 10, 2023
|
Size Change: +268 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4e5923e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4665651039
|
alexstine
reviewed
Apr 10, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48457
What?
This PR updates the command center to rely on the keyboard shortcuts to define its cmd+k shortcut. This allows the shortcut to work in all operating systems and also it shows the shortcut in the "shortcuts modal" of the editor.
Testing Instructions
1- Open the experiments page and enable the command center.
2- Open the site editor and focus the page.
3- Use cmd+k or ctrl+k (I guess) depending on your operating system (you might want to check the right combination in the keyboard shortcuts modal)
4- The command center should show up.