Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the docs for Playwright config override #49660

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Remove the docs for Playwright config override #49660

merged 1 commit into from
Apr 8, 2023

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Apr 7, 2023 •
edited
Loading

What?

In #49329 @kevin940726 explained we should not document the overriding of playwright and the PR got merged with the docs in.

Why?

Because it was approved already and I thought I removed the docs.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@draganescu draganescu marked this pull request as ready for review April 7, 2023 15:38
@draganescu draganescu mentioned this pull request Apr 7, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Flaky tests detected in 9761f10.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4639388112
📝 Reported issues:

alexstine
alexstine approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

kevin940726
kevin940726 approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@kevin940726 kevin940726 merged commit 4fa2a87 into trunk Apr 8, 2023
@kevin940726 kevin940726 deleted the fix/bad-docs branch April 8, 2023 11:59
@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 8, 2023
@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

@kevin940726 kevin940726 kevin940726 approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 15.6
Development

Successfully merging this pull request may close these issues.
4 participants
@draganescu @kevin940726 @alexstine @ndiego