Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Allow horizontal scroll in panels in the post editor #49611

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

cawa-93
Copy link
Contributor

@cawa-93 cawa-93 commented Apr 5, 2023

What?

Fix #49610

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cawa-93! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@andrewserong andrewserong added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended labels Apr 6, 2023
@andrewserong andrewserong changed the title fix: allow horisontal scroll in panels List View: Allow horizontal scroll in panels Apr 6, 2023
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing up this issue @cawa-93. I've taken this for a spin and it appears to be testing nicely:

✅ With a heavily nested list view, once the list view items go past the right edge of the container, a horizontal scrollbar is introduced
✅ The document outline view is unaffected in its empty headings state
✅ The document outline view is unaffected in a post with lots of long headings at various levels

Scrollbar introduced When scrolled right, block settings are now clickable
image image

There are likely further follow-ups to be made to improve how deeply nested lists behave (e.g. the adjustments to spacing over in #49600), but for now, I think this is a good step to ensure the block settings buttons are accessible.

LGTM 👍

@andrewserong andrewserong changed the title List View: Allow horizontal scroll in panels List View: Allow horizontal scroll in panels in the post editor Apr 6, 2023
@talldan talldan merged commit 7a54880 into WordPress:trunk Apr 6, 2023
@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 6, 2023
@cawa-93 cawa-93 deleted the patch-1 branch April 6, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Overview overflowing
3 participants