Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the media-categories component #49047

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Fix typo in the media-categories component #49047

merged 6 commits into from
Mar 14, 2023

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Mar 13, 2023

What?

This PR fixes a typo in the media-categories component.

While I was translating the WordPress to Portuguese (PT-BR), I noticed that a placeholder in a sprintf function was using a different position compared with the hint for translators.

Why?

This PR is necessary to show the correct hint for translators.

How?

Updating to use the correct placeholder position.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

image

alexstine
alexstine approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. 👍

@alexstine
Copy link
Contributor

@Mamaduka Is this one needed for backporting? The translation strings do clearly look wrong here.

@Mamaduka Mamaduka added Internationalization (i18n) Issues or PRs related to internationalization efforts Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Mar 14, 2023
@Mamaduka
Copy link
Member

Thanks for the ping, @alexstine! Added label for the backporting.

@Mamaduka Mamaduka merged commit c2dfd23 into WordPress:trunk Mar 14, 2023
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 14, 2023
@alexstine
Copy link
Contributor

@Mamaduka Thanks. I am never positive on what should be eligible for backport and what is not. The whole idea of trying to figure out which portions of Gutenberg go out in a release is a terrible experience. Maybe it is documented somewhere but I have never found a clear way. Anyway, that is slightly off topic.

@Mamaduka
Copy link
Member

It's a bit tricky during the RC phase, but we're already backporting one internalization fix, and I'm also okay with including this one.

Generally, we try to use the release project board for triaging and tracking fixes that need to be backported.

@Mamaduka
Copy link
Member

I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: c1d64c0

Mamaduka pushed a commit that referenced this pull request Mar 14, 2023
@Rahmon @Mamaduka
i18n: Fix the typo in the media categories component (#49047)
c1d64c0
@Mamaduka Mamaduka removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 14, 2023
@Rahmon Rahmon deleted the fix/typo-media-categories branch March 14, 2023 10:44
@hellofromtonya
Copy link
Contributor

The threshold for deciding what to backport in Core's RC cycle is this:

Was the string introduced in the 6.2 cycle?

If yes, then it's okay to backport. cc @Mamaduka

@hellofromtonya hellofromtonya mentioned this pull request Mar 14, 2023
Closed
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 14, 2023
@hellofromtonya
Editor: Update @WordPress packages for 6.2 RC2.
48deabc 
Updates the `@wordpress` packages to include the following changes:

- [Regression] Don't offer Classic block as a recovery action when not registered [WordPress/gutenberg#49051 Gutenberg PR 49051] ✅ 
- [i18n Change] Fix typo in the media-categories component [WordPress/gutenberg#49047 Gutenberg PR 49047] ✅
- Hide navigation screen in site editor [WordPress/gutenberg#49043 Gutenberg PR 49043] ✅ 
 [https://make.wordpress.org/core/2023/03/14/fyi-navigation-section-of-new-site-editor-experienced-removed-for-6-2-rc-2/ Feature is not ready for 6.2]
- [i18n Change] Site editor: Fix non-us spelling in sidebar [WordPress/gutenberg#48976 Gutenberg PR 48976] ✅ See Trac #57895.
- [Regression] Site Editor: Fix lingering insertion point within template parts [WordPress/gutenberg#48913 Gutenberg PR 48913] ✅ > Regression introduced in 6.2 cycle.
- Navigation Link: Remove color generation code [WordPress/gutenberg#48927 Gutenberg PR 48927] and [WordPress/gutenberg#49064 Gutenberg PR 49064] ✅
- Fix settings tab active state border in block inspector [WordPress/gutenberg#48945 Gutenberg PR 48945] ✅
- Fix text alignment in the Site Editor sidebar  [WordPress/gutenberg#48959 Gutenberg PR 48959] ✅ Making template descriptions more prominent is part of 6.2.

References:
* [WordPress/gutenberg@f22a3cb Packages x.3.9 publish commit]
* [WordPress/gutenberg@356298f Packages x.3.10 publish commit]

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
See #57471.
Fixes #57895.
Built from https://develop.svn.wordpress.org/trunk@55542


git-svn-id: http://core.svn.wordpress.org/trunk@55054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Mar 14, 2023
@hellofromtonya
Editor: Update @WordPress packages for 6.2 RC2.
f71da79 
Updates the `@wordpress` packages to include the following changes:

- [Regression] Don't offer Classic block as a recovery action when not registered [WordPress/gutenberg#49051 Gutenberg PR 49051] ✅ 
- [i18n Change] Fix typo in the media-categories component [WordPress/gutenberg#49047 Gutenberg PR 49047] ✅
- Hide navigation screen in site editor [WordPress/gutenberg#49043 Gutenberg PR 49043] ✅ 
 [https://make.wordpress.org/core/2023/03/14/fyi-navigation-section-of-new-site-editor-experienced-removed-for-6-2-rc-2/ Feature is not ready for 6.2]
- [i18n Change] Site editor: Fix non-us spelling in sidebar [WordPress/gutenberg#48976 Gutenberg PR 48976] ✅ See Trac #57895.
- [Regression] Site Editor: Fix lingering insertion point within template parts [WordPress/gutenberg#48913 Gutenberg PR 48913] ✅ > Regression introduced in 6.2 cycle.
- Navigation Link: Remove color generation code [WordPress/gutenberg#48927 Gutenberg PR 48927] and [WordPress/gutenberg#49064 Gutenberg PR 49064] ✅
- Fix settings tab active state border in block inspector [WordPress/gutenberg#48945 Gutenberg PR 48945] ✅
- Fix text alignment in the Site Editor sidebar  [WordPress/gutenberg#48959 Gutenberg PR 48959] ✅ Making template descriptions more prominent is part of 6.2.

References:
* [WordPress/gutenberg@f22a3cb Packages x.3.9 publish commit]
* [WordPress/gutenberg@356298f Packages x.3.10 publish commit]

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
See #57471.
Fixes #57895.
Built from https://develop.svn.wordpress.org/trunk@55542


git-svn-id: https://core.svn.wordpress.org/trunk@55054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Mar 14, 2023
@hellofromtonya
Editor: Update @WordPress packages for 6.2 RC2.
a71a9bc 
Updates the `@wordpress` packages to include the following changes:

- [Regression] Don't offer Classic block as a recovery action when not registered [WordPress/gutenberg#49051 Gutenberg PR 49051] ✅ 
- [i18n Change] Fix typo in the media-categories component [WordPress/gutenberg#49047 Gutenberg PR 49047] ✅
- Hide navigation screen in site editor [WordPress/gutenberg#49043 Gutenberg PR 49043] ✅ 
 [https://make.wordpress.org/core/2023/03/14/fyi-navigation-section-of-new-site-editor-experienced-removed-for-6-2-rc-2/ Feature is not ready for 6.2]
- [i18n Change] Site editor: Fix non-us spelling in sidebar [WordPress/gutenberg#48976 Gutenberg PR 48976] ✅ See Trac #57895.
- [Regression] Site Editor: Fix lingering insertion point within template parts [WordPress/gutenberg#48913 Gutenberg PR 48913] ✅ > Regression introduced in 6.2 cycle.
- Navigation Link: Remove color generation code [WordPress/gutenberg#48927 Gutenberg PR 48927] and [WordPress/gutenberg#49064 Gutenberg PR 49064] ✅
- Fix settings tab active state border in block inspector [WordPress/gutenberg#48945 Gutenberg PR 48945] ✅
- Fix text alignment in the Site Editor sidebar  [WordPress/gutenberg#48959 Gutenberg PR 48959] ✅ Making template descriptions more prominent is part of 6.2.

References:
* [WordPress/gutenberg@f22a3cb Packages x.3.9 publish commit]
* [WordPress/gutenberg@356298f Packages x.3.10 publish commit]

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [55542] to the 6.2 branch.
See #57471.
Fixes #57895.

git-svn-id: https://develop.svn.wordpress.org/branches/6.2@55548 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 14, 2023
@hellofromtonya
Editor: Update @WordPress packages for 6.2 RC2.
7592613 
Updates the `@wordpress` packages to include the following changes:

- [Regression] Don't offer Classic block as a recovery action when not registered [WordPress/gutenberg#49051 Gutenberg PR 49051] ✅ 
- [i18n Change] Fix typo in the media-categories component [WordPress/gutenberg#49047 Gutenberg PR 49047] ✅
- Hide navigation screen in site editor [WordPress/gutenberg#49043 Gutenberg PR 49043] ✅ 
 [https://make.wordpress.org/core/2023/03/14/fyi-navigation-section-of-new-site-editor-experienced-removed-for-6-2-rc-2/ Feature is not ready for 6.2]
- [i18n Change] Site editor: Fix non-us spelling in sidebar [WordPress/gutenberg#48976 Gutenberg PR 48976] ✅ See Trac #57895.
- [Regression] Site Editor: Fix lingering insertion point within template parts [WordPress/gutenberg#48913 Gutenberg PR 48913] ✅ > Regression introduced in 6.2 cycle.
- Navigation Link: Remove color generation code [WordPress/gutenberg#48927 Gutenberg PR 48927] and [WordPress/gutenberg#49064 Gutenberg PR 49064] ✅
- Fix settings tab active state border in block inspector [WordPress/gutenberg#48945 Gutenberg PR 48945] ✅
- Fix text alignment in the Site Editor sidebar  [WordPress/gutenberg#48959 Gutenberg PR 48959] ✅ Making template descriptions more prominent is part of 6.2.

References:
* [WordPress/gutenberg@f22a3cb Packages x.3.9 publish commit]
* [WordPress/gutenberg@356298f Packages x.3.10 publish commit]

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [55542] to the 6.2 branch.
See #57471.
Fixes #57895.
Built from https://develop.svn.wordpress.org/branches/6.2@55548


git-svn-id: http://core.svn.wordpress.org/branches/6.2@55060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
Gutenberg 15.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Rahmon @alexstine @Mamaduka @hellofromtonya