Tests: Cleanup unnecessary jest timers setup #49030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
requested review from
ajitbohra,
gziolo,
getdave,
ellatrix and
nerrad
as code owners
tyxla
commented
Mar 13, 2023
| @@ -51,8 +51,6 @@ jest.mock( '@wordpress/data/src/components/use-dispatch', () => ( { | |||
| useDispatch: () => ( { saveEntityRecords: jest.fn() } ), | |||
| } ) ); | |||
|
|
|||
| jest.useRealTimers(); | |||
There was a problem hiding this comment.
None of those are necessary since we already default to using real timers.
| @@ -8,7 +8,9 @@ import { render } from '@testing-library/react'; | |||
| */ | |||
| import { AutosaveMonitor } from '../'; | |||
|
|
|||
| jest.useFakeTimers( { legacyFakeTimers: true } ); | |||
| jest.useFakeTimers(); | |||
There was a problem hiding this comment.
It wasn't necessary to use the legacy fake timers, so I removed that.
| @@ -8,7 +8,9 @@ import { render } from '@testing-library/react'; | |||
| */ | |||
| import { AutosaveMonitor } from '../'; | |||
|
|
|||
| jest.useFakeTimers( { legacyFakeTimers: true } ); | |||
| jest.useFakeTimers(); | |||
| jest.spyOn( global, 'clearTimeout' ); | |||
There was a problem hiding this comment.
However, it was necessary to start spying on clearTimeout and setTimeout, as also displayed on the jest docs page.
It's odd that it worked before. I assume some cross-test-setup bleeding was going on.
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 4e31a36. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4405501538
|
ntsekouras
approved these changes
Mar 13, 2023
Mamaduka
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When opening #49029 I noticed that we still specifically enable real timers in a bunch of places, even though those are already the default timers. This PR cleans those up.
Why?
Just cleaning up.
How?
We're just removing a few unnecessary
jest.useRealTimers()Testing Instructions
Verify all tests are still green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None