Update: Move the global styles provider to the app level component. #49011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
update/move-the-global-styles-provider-to-the-app-level-component
branch
jorgefilipecosta
added a commit
that referenced
this pull request
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the global styles provider to be a top level app component.
There are plans to move the global styles sidebar as a top level browse mode sidebar item. For that work to happen, the Global Styles sidebar needs access to the global styles provider.
Testing
Verify the global styles sidebar continues to work exactly as before and change are applied both in site editor and front end of the site.