Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON schema: Add sticky position to settings, minHeight to styles #48948

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Theme JSON schema: Add sticky position to settings, minHeight to styles #48948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd0a431
Theme JSON schema: Add sticky position to settings
andrewserong Mar 9, 2023
1fc9c3a
Add dimensions.minHeight to styles
andrewserong Mar 9, 2023
a6c8eea
Add missing type: objects line
andrewserong Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/reference-guides/theme-json-reference/theme-json-living.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,16 @@ Settings related to layout.

---

### position

Settings related to position.

| Property | Type | Default | Props |
| --- | --- | --- |--- |
| sticky | boolean | false | |

---

### spacing

Settings related to spacing.
Expand Down Expand Up @@ -181,6 +191,16 @@ Color styles.

---

### dimensions

Dimensions styles

| Property | Type | Props |
| --- | --- |--- |
| minHeight | string, object | |

---

### spacing

Spacing styles.
Expand Down
43 changes: 42 additions & 1 deletion schemas/json/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@
}
},
"settingsPropertiesDimensions": {
"type": "object",
"properties": {
"dimensions": {
"description": "Settings related to dimensions.",
Expand Down Expand Up @@ -267,6 +268,23 @@
}
}
},
"settingsPropertiesPosition": {
"type": "object",
"properties": {
"position": {
"description": "Settings related to position.",
"type": "object",
"properties": {
"sticky": {
"description": "Allow users to set sticky position.",
"type": "boolean",
"default": false
}
},
"additionalProperties": false
}
}
},
"settingsPropertiesSpacing": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -625,8 +643,10 @@
{ "$ref": "#/definitions/settingsPropertiesAppearanceTools" },
{ "$ref": "#/definitions/settingsPropertiesBorder" },
{ "$ref": "#/definitions/settingsPropertiesColor" },
{ "$ref": "#/definitions/settingsPropertiesDimensions" },
{ "$ref": "#/definitions/settingsPropertiesShadow" },
{ "$ref": "#/definitions/settingsPropertiesLayout" },
{ "$ref": "#/definitions/settingsPropertiesPosition" },
{ "$ref": "#/definitions/settingsPropertiesSpacing" },
{ "$ref": "#/definitions/settingsPropertiesTypography" },
{ "$ref": "#/definitions/settingsPropertiesCustom" }
Expand All @@ -642,9 +662,11 @@
"properties": {
"appearanceTools": {},
"border": {},
"shadow": {},
"color": {},
"dimensions": {},
"layout": {},
"position": {},
"shadow": {},
"spacing": {},
"typography": {},
"custom": {}
Expand Down Expand Up @@ -1258,6 +1280,23 @@
},
"additionalProperties": false
},
"dimensions": {
"description": "Dimensions styles",
"type": "object",
"properties": {
"minHeight": {
"description": "Sets the `min-height` CSS property.",
"oneOf": [
{
"type": "string"
},
{
"$ref": "#/definitions/refComplete"
}
]
}
}
},
"spacing": {
"description": "Spacing styles.",
"type": "object",
Expand Down Expand Up @@ -1573,6 +1612,7 @@
"properties": {
"border": {},
"color": {},
"dimensions": {},
"spacing": {},
"typography": {},
"filter": {},
Expand Down Expand Up @@ -1949,6 +1989,7 @@
"properties": {
"border": {},
"color": {},
"dimensions": {},
"spacing": {},
"typography": {},
"filter": {},
Expand Down