Post Editor: Fix animation and browser console error when returning from template edit mode #48930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom template edit mode
|
Size Change: -3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Mar 13, 2023
|
Thanks for the review, @carolinan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes two problems that occur when returning from post template editor mode.
Why?
The following error message will appear:
This warning message does not seem to be displaying the correct warning, but perhaps it needs to be set to a numeric
0instead of a string"0". From the motion document, it appears that 0 is assumed to be of type Number, although this is not explicitly stated.Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4