Fix: Site button metrics #48918
Merged
Fix: Site button metrics #48918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
jameskoster
approved these changes
Mar 8, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 3ac9a1f |
Mamaduka
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The "exit fullscreen" button in the site editor is too wide. 60x64:
This appears to be due to #47120 which corrected these metrics for the site hub. But the site hub is visually changing again, so it seems this CSS is no longer correct. This PR removes the 4px:
That makes the button 60x60 again.
Testing Instructions
Test the site editor and validate that the site back button is 60x60.