Fix grouping actions in List View #48910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #48905, the grouping actions in List View will sometimes operate on the wrong blocks, as the code was written with selected blocks in mind. In List View it's possible to group non-selected blocks.
(kudos to @andrewserong for spotting this)
How?
The fix is a little different (actually simpler) as the grouping options don't use a
BlockSettingsMenuControls, but they do still have access to the same list ofclientIds.I've updated the
useConvertToGroupButtonPropshook, which is a kind of ubiquitous grouping intermediary, to optionally accept those clientIds. When provided it'll bypass using thegetSelectedBlockClientIdsselector.Testing Instructions
Expected: The correct block should be grouped
In trunk: The wrong block is grouped
Screenshots or screencast
Before
Kapture.2023-03-08.at.15.34.40.mp4
After
Kapture.2023-03-08.at.15.32.20.mp4