Fix navigation block off-canvas appender for empty menus #48907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the parent client id in as a prop instead of trying to determine the id from inner blocks
talldan
added
[Type] Bug
talldan
added
the
Backport to WP 6.7 Beta/RC
|
Thanks, Dan! I also noticed this just now while working on a separate issue. |
|
Size Change: +2 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 8, 2023
aaronrobertshaw
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks for fixing this @talldan 👍
I could replicate the issue on trunk and this PR fixes it for me. While I'm not hugely familiar with the workings of the Off Canvas Editor, the code changes make sense to me.
| Before | After |
|---|---|
 |
 |
|
Thanks @talldan 👍 |
Mamaduka
pushed a commit
that referenced
this pull request
Mar 9, 2023
- Pass the parent client id in as a prop instead of trying to determine the id from inner blocks
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 9410fd7. |
Mamaduka
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue with the navigation block's off canvas appender, where when trying to add a block to an empty menu, the pattern view of the quick inserter was being shown instead of the list of block types.
How?
The issue is that the parent client id (the client id of the navigation block) was being determined by checking the parent of the first child block.
When there are no inner blocks, this fails and the quick inserter thinks a block is being inserted at the root level, so shows patterns instead of block types.
The fix is to pass the parent client id as a prop of the
OffCanvasEditor. Previously I think this was avoided because it would make it hard to merge this code back into the mainListViewcomponent, but that code was written when empty menus had no appender.I think it's better to fix this bug now for WordPress 6.2 and think about a more general solution to the differences between
OffCanvasEditorandListViewlater.The
OffCanvasEditoris private, so there's no detriment to external APIs.Testing Instructions
Expected: It should show a list of block types
In trunk: It shows patterns
Screenshots or screencast
Before
After