[Query Loop]: Show variant patterns even if there are no patterns for the Query Loop block #48793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Query Loop block
ntsekouras
added
[Type] Bug
|
Size Change: +11 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
I just tested this with my local test case and it works as expected 🎉 |
fabiankaegy
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
This works as intended and the code does exactly what I would have thought :) Just much cleaner than my initial exploration in #48795
ndiego
approved these changes
Mar 6, 2023
ndiego
added
the
Backport to WP 6.7 Beta/RC
fabiankaegy
pushed a commit
that referenced
this pull request
Mar 6, 2023
… the Query Loop block (#48793)
|
(Not sure what the process usually looks like but just in case to make it easier, I created a PR that cherry picks the commit from this PR to the |
|
Thank you @fabiankaegy, but we don't need a new PR for the backport process here - we just |
ntsekouras
added a commit
that referenced
this pull request
Mar 7, 2023
… the Query Loop block (#48793)
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 4ef5878 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48788
Testing instructions are on the issue.